-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add random option #7950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add random option #7950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
| case UpstreamModeParallel: | ||
| conf.UpstreamMode = proxy.UpstreamModeParallel | ||
| case UpstreamModeRandom: | ||
| conf.UpstreamMode = proxy.UpstreamModeRandom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't build without go.mod modifications. You can set the dnsproxy version to the one from your branch, temporarily, via go get.
| - 'fastest' | ||
| - 'load_balancing' | ||
| - 'parallel' | ||
| - 'random' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update both CHANGELOG.md (that one uses KeepAChangelog standard) and openapi/CHANGELOG.md adding this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand, more changes to the frontend are required?
Updates #4756
PR required for dnsproxy
AdguardTeam/dnsproxy#467